Skip to content

Conversation

@senekor
Copy link
Contributor

@senekor senekor commented Sep 30, 2025

Related forum post:
https://forum.exercism.org/t/test-runner-fail-on-paas/19426

[no important files changed]

@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor force-pushed the senekor/onmwnwkkxlqy branch from bd42f49 to 8e6c085 Compare September 30, 2025 10:31
@senekor senekor changed the base branch from main to senekor/vwyqynookrtv September 30, 2025 10:31
@senekor senekor force-pushed the senekor/vwyqynookrtv branch from 7967fa3 to ffe4607 Compare September 30, 2025 10:33
@senekor senekor force-pushed the senekor/onmwnwkkxlqy branch from 8e6c085 to 8d48377 Compare September 30, 2025 10:33
@senekor senekor requested a review from ellnix September 30, 2025 10:37
Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug and creative solution. I don't think we can set the panicked flag inside the BufWriter, although I assume that would work around this.

I think in addition to the comment explaining why this is done, we should include a link to the forum discussion.

Base automatically changed from senekor/vwyqynookrtv to main September 30, 2025 13:57
@senekor senekor force-pushed the senekor/onmwnwkkxlqy branch from 8d48377 to 162c9bb Compare September 30, 2025 14:01
@senekor
Copy link
Contributor Author

senekor commented Sep 30, 2025

I think in addition to the comment explaining why this is done, we should include a link to the forum discussion.

Done 👍

@senekor senekor merged commit 6f4d44c into main Sep 30, 2025
10 checks passed
@senekor senekor deleted the senekor/onmwnwkkxlqy branch September 30, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants