Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .eslintignore

This file was deleted.

8 changes: 8 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,13 @@
"excludedFiles": ["custom.test.ts"],
"extends": "@exercism/eslint-config-typescript/maintainers"
}
],
"ignores": [
"!.meta",
".appends",
".git",
".vscode",
"/bin",
"/config"
]
}
13 changes: 0 additions & 13 deletions common/.eslintignore

This file was deleted.

11 changes: 10 additions & 1 deletion common/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
parserOptions: {
languageOptions: {
tsconfigRootDir: __dirname,
project: ['./tsconfig.json'],
},
Expand Down Expand Up @@ -35,4 +35,13 @@ module.exports = {
extends: '@exercism/eslint-config-typescript/maintainers',
},
],
ignores: [
"!.meta",
".git",
".vscode",
"node_modules/*",
".eslintrc.cjs",
"babel.config.cjs",
"jest.config.cjs",
],
}
13 changes: 0 additions & 13 deletions exercises/practice/dnd-character/.eslintignore

This file was deleted.

11 changes: 10 additions & 1 deletion exercises/practice/dnd-character/.eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
parserOptions: {
languageOptions: {
tsconfigRootDir: __dirname,
project: ['./tsconfig.json'],
},
Expand Down Expand Up @@ -35,4 +35,13 @@ module.exports = {
extends: '@exercism/eslint-config-typescript/maintainers',
},
],
ignores: [
"!.meta",
".git",
".vscode",
"node_modules/*",
".eslintrc.cjs",
"babel.config.cjs",
"jest.config.cjs",
],
}
26 changes: 25 additions & 1 deletion exercises/practice/dnd-character/dnd-character.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,27 +75,51 @@ describe('Ability generator', () => {
})

describe('Character creation', () => {
xit('Random character is valid', () => {
xit('Random character is valid - hitpoints', () => {
const character = new DnDCharacter()

expect(character.hitpoints).toEqual(
10 + DnDCharacter.getModifierFor(character.constitution)
)
})

xit('Random character is valid - strength', () => {
const character = new DnDCharacter()

expect(character.strength).toBeGreaterThanOrEqual(3)
expect(character.strength).toBeLessThanOrEqual(18)
})

xit('Random character is valid - dexterity', () => {
const character = new DnDCharacter()

expect(character.dexterity).toBeGreaterThanOrEqual(3)
expect(character.dexterity).toBeLessThanOrEqual(18)
})

xit('Random character is valid - constitution', () => {
const character = new DnDCharacter()

expect(character.constitution).toBeGreaterThanOrEqual(3)
expect(character.constitution).toBeLessThanOrEqual(18)
})

xit('Random character is valid - intelligence', () => {
const character = new DnDCharacter()

expect(character.intelligence).toBeGreaterThanOrEqual(3)
expect(character.intelligence).toBeLessThanOrEqual(18)
})

xit('Random character is valid - wisdom', () => {
const character = new DnDCharacter()

expect(character.wisdom).toBeGreaterThanOrEqual(3)
expect(character.wisdom).toBeLessThanOrEqual(18)
})

xit('Random character is valid - charisma', () => {
const character = new DnDCharacter()

expect(character.charisma).toBeGreaterThanOrEqual(3)
expect(character.charisma).toBeLessThanOrEqual(18)
Expand Down
8 changes: 4 additions & 4 deletions exercises/practice/dnd-character/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
"devDependencies": {
"@exercism/babel-preset-typescript": "^0.4.0",
"@exercism/eslint-config-typescript": "^0.5.0",
"@types/jest": "^29.5.2",
"@types/jest": "^29.5.12",
"@types/node": "~18.16.16",
"babel-jest": "^29.5.0",
"babel-jest": "^29.7.0",
"core-js": "~3.30.2",
"eslint": "^8.42.0",
"jest": "^29.5.0",
"eslint": "^9.2.0",
"jest": "^29.7.0",
"typescript": "~5.0.4"
},
"scripts": {
Expand Down
1 change: 0 additions & 1 deletion scripts/helpers.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export const COMMON_DIRS = [
]
export const COMMON_FILES = [
path.join('.yarn', 'releases', 'yarn-3.6.4.cjs'),
'.eslintignore',
'.eslintrc.cjs',
'.yarnrc.yml',
'babel.config.cjs',
Expand Down
2 changes: 1 addition & 1 deletion scripts/lint.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const failureStr = '[Failure] Lint check failed!'

// Run lint all at once
prepareAndRun(
'yarn eslint tmp_exercises --ext .ts --ext .tsx -c node_modules/@exercism/eslint-config-typescript/maintainers.js',
'yarn eslint tmp_exercises -c node_modules/@exercism/eslint-config-typescript/maintainers.js',
infoStr,
failureStr
)
Expand Down