Conversation
The handleSyncEverything function was a standalone exported function that called useAppTranslation (a React hook), violating the Rules of Hooks. It was called from onClick handlers, outside the component render cycle. Move the logic into useCallback hooks inside the respective components, matching the pattern already used by handleSyncSingleTrack. Closes #8452 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8452
Summary
handleSyncEverythingfunction was a standalone exported function that calleduseAppTranslation()(a React hook), violating the Rules of Hooks — it was invoked fromonClickhandlers, outside the component render cycleuseCallbackhooks insideManualSyncSectionandJustConnectedModal, matching the pattern already used byhandleSyncSingleTrackTest plan
yarn testpasses (160/160 suites, 1550/1550 tests)🤖 Generated with Claude Code