Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Conversation

@michaelavila
Copy link
Contributor

Here is a minimal solution to issue #7. If you have more in mind let me know, but for now I figure this will be better than nothing.

@kytrinyx
Copy link
Member

kytrinyx commented Mar 2, 2014

This seems like a great minimal solution. Could you delete the /lib/app/public/install script, though?

@michaelavila
Copy link
Contributor Author

I didn't even realize it was there. Still familiarizing myself with everything. Let me know if there's anything else you notice out of place.

@kytrinyx
Copy link
Member

kytrinyx commented Mar 2, 2014

Nope, the rest all looks fine. Thanks!

@michaelavila
Copy link
Contributor Author

If you want to do something different here just let me know.

@kytrinyx
Copy link
Member

kytrinyx commented Mar 2, 2014

No, I just forgot to check back here.

I looked through the list of new files and also saw this one lib/app/public/exercism_completion.bash.

Would you mind taking it out, rebasing onto master, squashing the commits, and pushing it up again? Sorry about the trouble!

@michaelavila
Copy link
Contributor Author

I've gone ahead and removed them all and squashed all of the commits. Good call.

@michaelavila
Copy link
Contributor Author

That extra commit just makes the landing page have the same updates as what we've done to CONTRIBUTING.

@kytrinyx
Copy link
Member

kytrinyx commented Mar 3, 2014

Awesome! ❤️

kytrinyx added a commit that referenced this pull request Mar 3, 2014
Add landing page that just has the contents of CONTRIBUTING.md
@kytrinyx kytrinyx merged commit 07d24ee into exercism:master Mar 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants