Skip to content

Update README.md and setup.py for Python modules [ECR-3992]#1296

Merged
dmitry-timofeev merged 3 commits into
exonum:masterfrom
vitvakatu:publish-python-modules
Dec 16, 2019
Merged

Update README.md and setup.py for Python modules [ECR-3992]#1296
dmitry-timofeev merged 3 commits into
exonum:masterfrom
vitvakatu:publish-python-modules

Conversation

@vitvakatu

Copy link
Copy Markdown
Contributor

Overview

Python modules have been published with the following changes.


See: https://jira.bf.local/browse/ECR-3992

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Ilya Bogdanov added 2 commits December 16, 2019 11:16
Fix Readme with recent changes in docs
Fix setup.py
@coveralls

coveralls commented Dec 16, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 86.397% when pulling dee4ddc on vitvakatu:publish-python-modules into 3e42098 on exonum:master.

@dmitry-timofeev

Copy link
Copy Markdown
Contributor

@popzxc Would you please review the extension updates?

@dmitry-timofeev

dmitry-timofeev commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Why does it use a different version from the rest of the project (on Pypi)?

@popzxc popzxc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitvakatu

Copy link
Copy Markdown
Contributor Author

Why does it use a different version from the rest of the project (on Pypi)?

A small oversight by me. PyPI doesn't like certain version formats, like 0.9.0-rc1, or 0.9.0-rc1.2 which are totally possible in semantic versioning. So I changed it to dev1 for testing purpose and forgot to change it back.

I published another release with version 0.9.0rc1, it is now available at PyPI.

@dmitry-timofeev

Copy link
Copy Markdown
Contributor

PyPI doesn't like certain version formats

Does it forbid some version strings, allowed by semver?

@popzxc

popzxc commented Dec 16, 2019

Copy link
Copy Markdown

Does it forbid some version strings, allowed by semver?

Even if it doesn't, it's not consistent with convention. Even the cpython project itself uses the following format:
image

@dmitry-timofeev
dmitry-timofeev merged commit cec51d7 into exonum:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants