fix unflatten padding when last element is empty #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix spaCy issue explosion/spaCy#3880. The error in that issue is raised by
ops.pyxon the lineassert len(X) == 0(https://github.com/explosion/thinc/blob/master/thinc/neural/ops.pyx#L138), and it happens when the tagger model is run with an empty doc as last element in a call tonlp.pipe().I think this happens because the
flattenfunction adds one additional bit of padding at the end (https://github.com/explosion/thinc/blob/master/thinc/neural/ops.pyx#L119) which is not stripped away whenunflattenremoves the padding only whenlength != 0(https://github.com/explosion/thinc/blob/master/thinc/neural/ops.pyx#L136) for the last variablelengthinlengths(accessed outside of itsforloop).I don't have a proper way of testing this yet, so I'm definitely not sure about this.