Skip to content

Handle promises with unavailable references if resolve=False#400

Merged
ines merged 3 commits intomasterfrom
fix/fill-unavailable-promises
Sep 27, 2020
Merged

Handle promises with unavailable references if resolve=False#400
ines merged 3 commits intomasterfrom
fix/fill-unavailable-promises

Conversation

@ines
Copy link
Copy Markdown
Member

@ines ines commented Sep 27, 2020

If we're just filling a config, promises that refer to registered functions that are not available should be ignored.

@ines ines added bug Bugs and behaviour differing from documentation feat / config Configuration system and config files labels Sep 27, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2020

Codecov Report

Merging #400 into master will increase coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   59.71%   59.74%   +0.03%     
==========================================
  Files          96       96              
  Lines        6622     6630       +8     
==========================================
+ Hits         3954     3961       +7     
- Misses       2668     2669       +1     
Impacted Files Coverage Δ
thinc/config.py 96.04% <90.00%> (-0.13%) ⬇️
thinc/about.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1f304...27e56aa. Read the comment docs.

@ines ines merged commit 32512f4 into master Sep 27, 2020
@ines ines deleted the fix/fill-unavailable-promises branch September 27, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs and behaviour differing from documentation feat / config Configuration system and config files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant