[eas-build-job] Add optional ssh field on job payloads - #4083
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
+ Coverage 62.27% 62.27% +0.01%
==========================================
Files 994 994
Lines 44733 44735 +2
Branches 9412 9412
==========================================
+ Hits 27852 27854 +2
Misses 15434 15434
Partials 1447 1447 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 25, 2026 04:22
70c5333 to
fb94788
Compare
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh-settings
branch
from
July 25, 2026 04:22
fd67320 to
77b34f0
Compare
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 27, 2026 00:24
fb94788 to
88f6a3b
Compare
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh-settings
branch
from
July 27, 2026 00:49
4cf6115 to
03fec90
Compare
This was referenced Jul 27, 2026
Contributor
Author
sjchmiela
approved these changes
Jul 28, 2026
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 29, 2026 22:13
88f6a3b to
8297089
Compare
Presence enables SSH; most jobs omit it, so match the TypeScript and Zod shapes.
.url() already rejects non-URLs before refine runs.
Prefer Zod 4 z.url({ protocol }) over z.string().url().refine for ws/wss.
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh-settings
branch
from
July 29, 2026 22:28
6973f85 to
0a7a451
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're putting SSH settings on the job itself instead of stuffing them into env.
wwwneeds the type on@expo/eas-build-jobfor that.How
Add an optional
sshfield on Generic and Build jobs.Test Plan
sshyarn testinpackages/eas-build-job