[reviewer] Report confidence + shipping impact, and summarize overall PR risk - #4128
Merged
Merged
Conversation
… PR risk Ports two reviewer-prompt sections from the euxy adopter repo (euxy 30e6117, refined by 4f1e0f8), re-anchored on this repo's house-calibrated severity anchors rather than copied. Findings now carry Confidence (is this real) and Impact if shipped (what it costs) as separate axes at the head of `rationale`, with the detailed reasoning folded into a <details> block. The house anchors sit at Medium impact: an exit-code regression, a --json/--non-interactive contract violation, a SystemError/UserError misclassification, a broken CHANGELOG entry. The coordinator folds `suggestion` into the rationale so the reporter cannot strand the fix below the collapsed block. The cross-cutting reviewer, or the always-run security reviewer when a PR is small enough to skip the cross-cutting pass, also emits one internal `__overall_pr_risk__` finding. The coordinator turns it into an `**Overall PR risk: Low|Medium|High.**` summary opener and then drops it. High risk names this repo's real blast radius: credential storage and retrieval, build and submit pipelines, env:exec, update publishing, and any change to an existing command's flags or output contract.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4128 +/- ##
=======================================
Coverage 62.64% 62.64%
=======================================
Files 999 999
Lines 45175 45175
Branches 9483 9483
=======================================
Hits 28294 28294
Misses 15433 15433
Partials 1448 1448 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brentvatne
added
the
ai-review
|
✅ Thank you for adding the changelog entry! |
🤖 AI code reviewDecision: Approve The specialist reviewers reported no critical or warning findings. No findings. This review is advisory — it never blocks a merge and never auto-approves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting over some changes to the ai-review output format. The goal is to surface risk for the overall PR and associated with each suggestion, and to keep detailed information within summary/details sections.