Skip to content

[eas-cli] Check non-interactive mode before fetching context in submit:cancel and submit:retry - #4141

Merged
brentvatne merged 2 commits into
mainfrom
brentvatne/submit-non-interactive-check
Aug 3, 2026
Merged

[eas-cli] Check non-interactive mode before fetching context in submit:cancel and submit:retry#4141
brentvatne merged 2 commits into
mainfrom
brentvatne/submit-non-interactive-check

Conversation

@brentvatne

Copy link
Copy Markdown
Member

Why

Follow-up to #4134, addressing @douglowder's review feedback: the "Submission ID must be provided in non-interactive mode" check ran after getContextAsync and getDisplayNameForProjectIdAsync. The command did network work before it failed on invalid input.

How

In submit:cancel and submit:retry, the non-interactive check now runs immediately after flag validation, before any context or project lookups. The getDisplayNameForProjectIdAsync call moved inside the interactive branch, since only the interactive submission picker uses the display name.

Test Plan

  • yarn typecheck, yarn lint, and yarn fmt:check pass.
  • eas submit:cancel --non-interactive and eas submit:retry --non-interactive (no submission ID) fail immediately with "Submission ID must be provided in non-interactive mode".
  • Interactive eas submit:cancel and eas submit:retry still list submissions with the project display name.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.43%. Comparing base (5694370) to head (bce0f76).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/submit/cancel.ts 0.00% 3 Missing ⚠️
packages/eas-cli/src/commands/submit/retry.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4141   +/-   ##
=======================================
  Coverage   62.43%   62.43%           
=======================================
  Files        1009     1009           
  Lines       45735    45735           
  Branches     9621     9621           
=======================================
  Hits        28548    28548           
- Misses      15724    15726    +2     
+ Partials     1463     1461    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

Overall PR risk: Medium. The change modifies existing behavior in the non-interactive submit cancel and retry paths. Scripts could observe a different validation order or error path when no submission ID exists. No reviewer reported a warning or critical finding.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@brentvatne
brentvatne merged commit d45bd93 into main Aug 3, 2026
13 checks passed
@brentvatne
brentvatne deleted the brentvatne/submit-non-interactive-check branch August 3, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants