Revert "[build-tools] Pin the default agent-device version for remote sessions (#4142)" - #4145
Closed
szdziedzic wants to merge 2 commits into
Closed
Revert "[build-tools] Pin the default agent-device version for remote sessions (#4142)"#4145szdziedzic wants to merge 2 commits into
szdziedzic wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4145 +/- ##
=======================================
Coverage 62.43% 62.43%
=======================================
Files 1009 1009
Lines 45735 45735
Branches 9621 9621
=======================================
Hits 28548 28548
Misses 15726 15726
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reverts #4142 ("[build-tools] Pin the default
agent-deviceversion for remote sessions").How
git revertof commit f56c054. The defaultagent-deviceversion for remote sessions goes back tolatestwhen thepackage_versioninput is not set:DEFAULT_AGENT_DEVICE_VERSIONis removed.packageVersionisstring | undefinedagain instartAgentDeviceDaemonAsync,startAgentDeviceDaemonFromGitAsync,cloneAgentDeviceAsync, andcreateAgentDevicePackageSpec.agent-device@latest, and the git clone omits--branchwhen no version is given.The CHANGELOG entry for #4142 stays in the
21.5.0section because that change already shipped in@expo/build-tools@21.5.1. A new entry under## mainrecords the revert.Test Plan
yarn typecheck— passes.yarn lint— passes (0 errors).yarn fmt:check— passes.yarn lint-changelog— passes.cd packages/build-tools && yarn test— 104 of 105 suites pass. The one failure issteps/functions/__tests__/repack.test.ts, which fails the same way on the base commitd003bffa(spawn yarn ENOENTin the local sandbox) and is unrelated to this change.🤖 Generated with Claude Code