Skip to content

[build-tools] Classify Argent session artifacts by MIME type - #4154

Merged
szdziedzic merged 2 commits into
mainfrom
szdziedzic-claude/argent-artifact-kind-from-mime
Aug 6, 2026
Merged

[build-tools] Classify Argent session artifacts by MIME type#4154
szdziedzic merged 2 commits into
mainfrom
szdziedzic-claude/argent-artifact-kind-from-mime

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Why

Currently all argent screenshots and recordings are classified as other type on website

How

Use mime type of argent artifacts to select correct kind and make it display nicely on website

Test Plan

Tests

@szdziedzic
szdziedzic marked this pull request as ready for review August 5, 2026 16:27
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.47%. Comparing base (9827171) to head (d1fd9d5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4154      +/-   ##
==========================================
+ Coverage   62.47%   62.47%   +0.01%     
==========================================
  Files        1008     1008              
  Lines       45772    45778       +6     
  Branches     9631     9632       +1     
==========================================
+ Hits        28590    28596       +6     
  Misses      15721    15721              
  Partials     1461     1461              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp gwdp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Aug 5, 2026
The Argent tool server reports a MIME type for every artifact, but the uploader discarded it and sent kind: undefined. Map PNG/JPEG to `screenshot` and MP4/QuickTime to `screen-recording` so the dashboard groups and labels them instead of showing a flat, unclassified file list.
@szdziedzic
szdziedzic force-pushed the szdziedzic-claude/argent-artifact-kind-from-mime branch from fe9a2cb to d1fd9d5 Compare August 6, 2026 08:10
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve

Overall PR risk: Low. The change is additive: it adds a MIME-type-to-kind lookup so uploadArgentArtifactAsync sends a classified kind value instead of always undefined. The affected surface is limited to labeling and grouping of Argent artifacts on the simulator session page. The kind value comes from a fixed allowlist map, and mimeType is validated as a string before the lookup, so there is no injection or credential exposure risk. No reviewer reported a critical or warning finding, so no code-level defects survived to report.

No findings.


This review is advisory — it never blocks a merge and never auto-approves.

@szdziedzic
szdziedzic merged commit e383931 into main Aug 6, 2026
11 checks passed
@szdziedzic
szdziedzic deleted the szdziedzic-claude/argent-artifact-kind-from-mime branch August 6, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants