[build-tools] Stop remote simulator sessions after max_idle_time_minutes without activity - #4157
Conversation
…tes without activity Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
4510039 to
54494b6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4157 +/- ##
==========================================
+ Coverage 62.43% 62.45% +0.02%
==========================================
Files 1008 1008
Lines 45730 45762 +32
Branches 9625 9637 +12
==========================================
+ Hits 28548 28577 +29
- Misses 15721 15724 +3
Partials 1461 1461 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ Thank you for adding the changelog entry! |
🤖 AI code reviewDecision: Approve Overall PR risk: Low. The change is additive: it adds an optional No findings. This review is advisory — it never blocks a merge and never auto-approves. |
Why
Now we have event logs for agent-device and argent and we can finally add
--max-idel-time-minutessetting to simulator session.How
eas/start_argent_remote_sessionandeas/start_agent_device_remote_sessionget a new optionalmax_idle_time_minutesinput. A missing value disables the timeout.waitForDeviceRunSessionStoppedAsyncand use it to stop a session when we go over max idle timeFor now only argent/agent-device session events count as activity. Interaction through the serve-sim web preview does not produce these events yet.
Deployment order
Test Plan
CI passes