Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 109 109
Lines 16114 15960 -154
Branches 1450 1431 -19
==========================================
- Hits 16114 15960 -154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax
branch
from
510ca93 to
4d6507c
Compare
wschurman
force-pushed
the
wschurman/02-23-chore_sqlfragment.todebugstring_-_getdebugstring
branch
from
1105c89 to
4810a38
Compare
wschurman
force-pushed
the
wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax
branch
from
4d6507c to
583626d
Compare
wschurman
force-pushed
the
wschurman/02-23-chore_sqlfragment.todebugstring_-_getdebugstring
branch
from
4810a38 to
0220f14
Compare
wschurman
force-pushed
the
wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax
branch
from
583626d to
e2a8183
Compare
wschurman
force-pushed
the
wschurman/02-23-chore_sqlfragment.todebugstring_-_getdebugstring
branch
from
0220f14 to
2ae9a09
Compare
quinlanj
approved these changes
Feb 24, 2026
Member
Author
Merge activity
|
wschurman
changed the base branch from
wschurman/02-23-chore_sqlfragment.todebugstring_-_getdebugstring
to
graphite-base/459
wschurman
force-pushed
the
wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax
branch
from
e2a8183 to
75c5caa
Compare
wschurman
deleted the
wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#457 added a new mechanism for specifying ORDER BY clauses using SQLFragment that aligns a lot better with the loader APIs than having separate
orderByRaw/orderByFragmentfields in the query modifiers.How
Replace all with the new consistent order by in order field, update code to handle that.
One neat side-effect is that we no longer need the hard-to-follow direction-specific ordering in deep methods like
buildTrigramExactMatchPrioritysince now we can have those just produce a SQLFragment and reverse the ordering the same as all the other pagination methods.Test Plan
Run all tests.