Skip to content

chore: deprecate loadManyByRawWhereClause#460

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause
Feb 25, 2026
Merged

chore: deprecate loadManyByRawWhereClause#460
wschurman merged 1 commit intomainfrom
wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented Feb 23, 2026

Why

Now that loadManyBySQL supports all the features of this method (including raw order by), deprecate it.

How

Mark as deprecated in docblock.

Test Plan

yarn tsc

Copy link
Copy Markdown
Member Author

wschurman commented Feb 23, 2026

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (15adeb8) to head (1af8c83).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #460    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       109            
  Lines        15960     15964     +4     
  Branches      1444       873   -571     
==========================================
+ Hits         15960     15964     +4     
Flag Coverage Δ
integration 23.05% <100.00%> (+0.01%) ⬆️
unittest 95.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman force-pushed the wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax branch from 510ca93 to 4d6507c Compare February 24, 2026 01:32
@wschurman wschurman force-pushed the wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause branch 2 times, most recently from 06aed91 to e7f38d3 Compare February 24, 2026 02:11
@wschurman wschurman force-pushed the wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax branch 2 times, most recently from 583626d to e2a8183 Compare February 24, 2026 02:45
@wschurman wschurman force-pushed the wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause branch from e7f38d3 to e39a296 Compare February 24, 2026 02:45
@wschurman wschurman requested review from ide and quinlanj February 24, 2026 16:07
Copy link
Copy Markdown
Member Author

wschurman commented Feb 25, 2026

Merge activity

  • Feb 25, 12:04 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 25, 12:13 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 25, 12:16 AM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-23-feat_convert_all_raw_order_bys_to_use_same_mechanism_and_syntax to graphite-base/460 February 25, 2026 00:09
@wschurman wschurman changed the base branch from graphite-base/460 to main February 25, 2026 00:12
@wschurman wschurman force-pushed the wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause branch from e39a296 to 1af8c83 Compare February 25, 2026 00:13
@wschurman wschurman merged commit c946630 into main Feb 25, 2026
3 checks passed
@wschurman wschurman deleted the wschurman/02-23-chore_deprecate_loadmanybyrawwhereclause branch February 25, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants