[eas-shared] Fix formatBytes returning wrong values for sizes >= 102.4 GB - #363
Merged
Merged
Conversation
The final GB fallback tier divided by a literal 1024 instead of by the accumulated multiplier (1024**3), so the result was short by 1024**2. formatBytes(200 * 1024**3) returned "209715200 GB" instead of "200 GB". Divide by multiplier, mirroring the MB fallback one tier up. Adds a table-driven jest regression test covering every tier. Co-Authored-By: Claude <noreply@anthropic.com>
gabrieldonadel
approved these changes
Aug 9, 2026
gabrieldonadel
left a comment
gabrieldonadel
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatBytesreturned wrong values for sizes ≥ 102.4 GB. The final GB fallback divided by the literal1024instead ofmultiplier(which is1024**3in that branch), soformatBytes(200 GB)returned"209715200 GB"instead of"200 GB". Every other tier correctly divides bymultiplier; only the GB fallback was wrong.Fix
One expression:
bytes / 1024→bytes / multiplier, mirroring the MB fallback on the line above verbatim.Test
New
files.test.tswith 8 cases spanning B / KB / MB / GB (incl. the 200 GB bug reproducer and a 1024 GB boundary).yarn test(eas-shared) — 20 passed, 0 failed.Authored by
@YuriNachos. Implementation written by acccc(Claude Code, GLM-5.2) worker under orchestrator acceptance — gate green (20 passed).