[staging] Pin snack / snackager / snackpub to the dev node pool#693
Merged
Conversation
Move the staging Snack workloads off the autoscaled NAP (Node Auto Provisioning) nodes and onto the dedicated GKE `development` node pool on general-central (project exponentjs), as part of the IaC node-pool consolidation. The development pool is labeled `pool=dev` and carries the taint `dedicated=dev:NoSchedule`. Each staging Deployment pod template now sets: - nodeSelector: pool=dev - toleration: dedicated=dev:NoSchedule The base manifests have no nodeSelector, so this is a plain additive strategic-merge patch wired through each staging overlay's existing patchesStrategicMerge list (matching the repo's established override mechanism). Production overlays are untouched and continue to schedule as before. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@byCedric could i get a review please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move the staging snack, snackager and snackpub deployments off the shared NAP pools onto the dedicated
developmentGKE node pool:nodeSelector: pool=dev+ tolerationdedicated=dev:NoSchedule.Why
Node-pool consolidation — staging workloads belong on the
developmentpool, off NAP.Compatibility (verified live)
developmentnodes.developmenttaint =dedicated=dev:NoSchedule(only) → toleration is sufficient.pool=dev+dedicated=dev; production overlays unchanged.🤖 Generated with Claude Code