Skip to content

provide a default entry point for ES modules, fixes #37#38

Closed
slhck wants to merge 1 commit into
expo:mainfrom
slhck:esm-module2
Closed

provide a default entry point for ES modules, fixes #37#38
slhck wants to merge 1 commit into
expo:mainfrom
slhck:esm-module2

Conversation

@slhck
Copy link
Copy Markdown

@slhck slhck commented Jul 26, 2022

This makes it possible to import the package from a pure ESM context.

Please do test in your local environment!

This makes it possible to import the package from a pure ESM context.
@ide
Copy link
Copy Markdown
Member

ide commented Jul 27, 2022

I'm not sure how this would fix the issue since the file build/index.js isn't referenced anywhere. I put up #41 which uses export =. It's on npm as 1.7.0-rc.0. Could you try it and let me know if it works in your project?

@slhck
Copy link
Copy Markdown
Author

slhck commented Jul 27, 2022

I checked 08eb4b7 and it works fine, thanks!

Will close this PR then, not sure what caused it to work.

@slhck slhck closed this Jul 27, 2022
@slhck slhck deleted the esm-module2 branch July 27, 2022 06:37
@ide
Copy link
Copy Markdown
Member

ide commented Jul 27, 2022

Thanks for checking. Published to npm as 1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants