Conversation
Why
---
Using `export =` is a good way to make TS emit code that works with both CJS and ESM as long as the consumer uses `esModuleInterop: true`.
How
---
Needed to use namespace merging so that the spawnAsync function could be the assigned export (`export =` allows only one thing to be exported from the entire file).
Removed `index.js` since we can import from the TS file directly.
Test Plan
---
- Types: Added TypeScript imports to the Jest test file, where types are checked.
- CJS: Unit test verifies that CJS imports work. Tested end-to-end:
```
npm pack
cd /tmp
mkdir test
cd test
npm init
yarn add <path to packed tgz>
node
await require('@expo/spawn-async')('echo', ['hi'])
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #37
Using
export =is a good way to make TS emit code that works with both CJS and ESM as long as the consumer usesesModuleInterop: true.How
Needed to use namespace merging so that the spawnAsync function could be the assigned export (
export =allows only one thing to be exported from the entire file).Removed
index.jssince we can import from the TS file directly.Test Plan