res.json only support code 200 when body is undefined

[ix-xerri]

I'm building a REST API and only need to send error codes from the server. Messages are being handled by the client.

res.json(200); works.

res.json(304); does not. 304 becomes the body with the status being changed to 200.

res.json(304, {}); works.

[jonathanong]

If your body is empty, send a 204 code not 200.

[ix-xerri]

I need to send 200 in cases like a successful post request or delete
request. I use res.json because my aka requests are of dataType: 'json'.

On 11 Jun 2013, at 19:06, Jonathan Ong notifications@github.com wrote:

If your body is empty, send a 204 code not 200, and don't use res.jaon.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1649#issuecomment-19275459
.

[sirlancelot]

Have a look at response.js@171

statusCode is only set when there are two arguments.

[jonathanong]

If your client doesn't recognize the 204 status code as equivalent to 200 without any body, it is a bug with the client. Personally, I would just send something, even just an "ok" message.

[tj]

json without a body is really weird, we should make that required if anything

[ix-xerri]

I omitted the ok because the client would purposely disregard it. So it's
extra data.

On 11 Jun 2013, at 21:22, Jonathan Ong notifications@github.com wrote:

If your client doesn't recognize the 204 status code as equivalent to 200
without any body, it is a bug with the client. Personally, I would just
send something, even just an "ok" message.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1649#issuecomment-19286012
.

[ix-xerri]

Thanks. Is it not possible to send an OK reply without any content in the
body? The content is not needed.

On 11 Jun 2013, at 21:07, Matthew Pietz notifications@github.com wrote:

Have a look at response.js@171https://github.com/visionmedia/express/blob/138d74ae/lib/response.js#L171

statusCode is only set when there are two arguments.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1649#issuecomment-19285053
.

[jonathanong]

thats what a 204 status code is.

[jonathanong]

you should just do

res.send(204)

or

res.statusCode = 204
res.end()

[ix-xerri]

Will try it out. Thanks everyone!

Matthew Xerri

On 12 Jun 2013, at 00:16, Jonathan Ong notifications@github.com wrote:

you should just do

res.statusCode = 204res.end()

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1649#issuecomment-19296089
.

[jaketrent]

res.send(204)

returns status 200 w/ '204' in body.

res.statusCode = 204
res.end()

works as expected and returns a 204 w/o a message body.

res.status(204).end()

also works as expected

[dougwilson]

FYI res.json(200); never worked as the OP thought it did; it sent the number "200" as the body and of course defaulted to the status code of 200; res.json takes either 1 argument of the JSON to send with the default status code OR two arguments where if the first is a number, it is the status code.