Skip to content

Fixed typo in res.redirect deprecate message. - #2395

Closed
iambchan wants to merge 1 commit into
expressjs:masterfrom
iambchan:master
Closed

Fixed typo in res.redirect deprecate message.#2395
iambchan wants to merge 1 commit into
expressjs:masterfrom
iambchan:master

Conversation

@iambchan

Copy link
Copy Markdown
Contributor

No description provided.

@Fishrock123 Fishrock123 added the pr label Oct 11, 2014
@dougwilson

Copy link
Copy Markdown
Contributor

Thank you!

@dougwilson

Copy link
Copy Markdown
Contributor

@Fishrock123 this was supposed to land in the 3.x branch, not master.

@dougwilson

Copy link
Copy Markdown
Contributor

@sam-github please stop adding the in progress label.

@Fishrock123

Copy link
Copy Markdown
Contributor

All PR's are in progress - it's pointless really.

@Fishrock123

Copy link
Copy Markdown
Contributor

Jeremiah Senkpiel this was supposed to land in the 3.x branch, not master.

oh. oups.

@dougwilson

Copy link
Copy Markdown
Contributor

Moved. It'll be in master eventually :)

@dougwilson dougwilson closed this Oct 11, 2014
@sam-github

Copy link
Copy Markdown

@dougwilson Sorry about this, I've no idea why this label is being applied (and I was completely offline 3 days ago, so I couldn't even have done it by accident).

@altsang I make no changes to express, I should probably have commit rights removed. Also, I suspect waffle is doing something to express in my name. Maybe you can report as a bug to them?

@dougwilson

Copy link
Copy Markdown
Contributor

@sam-github I figured it was automated, but I thought you would be able to determine the source. I had even tried deleting the in progress label, but whatever the automated system is just re-creates the label.

@sam-github

Copy link
Copy Markdown

@dougwilson I've reported to Waffle, they might be able to explain. And I'll try to lose my commit bit, which will probably not prevent the label, but will remove me from the conversation :-)

@dougwilson

Copy link
Copy Markdown
Contributor

Thanks @sam-github :) I think they just reached out in another issue and said it should be fixed (at least for strongloop/express).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants