`if (!module.parent)` should be `if (module === require.main)`

[indexzero]

FYI.

Isaac Schlueter 4:52
well, the "correct" way to check that would be if (module === require.main)

We've got a related issue in haibu with a workaround coming, but since this is in the default app.js script for express, it seems worthwhile to change if it's not "correct" (for what it's worth).

[tj]

I'll probably just remove it all together, doesn't need to be there by default since it was originally only there for spark, and spark sucks

[tj]

people can add it in if they want that for testing etc

[indexzero]

@visionmedia Cool. There is a pretty easy work around for it. We will keep this in haibu for legacy support.

https://github.com/nodejitsu/haibu/issues/11#issuecomment-1215527

We will probably write a blog post about this to help express users migrate away from it.

[tj]

sounds good, not sure how many people are actually using the little template thing, node's module system has gone through so many changes I didn't even know there was a canonical way to go about this, much like the module.exports = everyone uses was not really intended but everyone uses it haha

[tj]

oh nice module.exports is actually documented now, maybe it wont be turfed then

[indexzero]

yeah, I was actually a little surprised that little patch worked, but it does