Closed
Conversation
dougwilson
force-pushed
the
readme-guidelines
branch
from
7357453 to
989f045
Compare
Contributor
|
Hey @crandmck just if you were wondering, I merged the simple edits to |
Member
Author
|
Thanks @dougwilson ... So can we land this PR? Or do I need to make some changes...? |
Contributor
|
Sorry, didn't get to really reading through the changes until now. My only comments are just minor tweaks, so not sure if you want to go through changes or just have me make them on landing (similar to expressjs.com PRs). |
Contributor
|
I guess I can update the PR directly as well :) |
dougwilson
force-pushed
the
readme-guidelines
branch
from
989f045 to
2a240c4
Compare
dougwilson
force-pushed
the
readme-guidelines
branch
from
2a240c4 to
1e6c8f7
Compare
Member
Author
|
Thanks @dougwilson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per expressjs/discussions#33 and expressjs/discussions#51 this PR adds a new
README-guidelines.mdfile with the content of the previously-reviewed file from the expressjs.com wiki. In this file, I added the "Contributing" section from https://github.com/mysqljs/mysql#contributing as suggested by @dougwilsonThe README guidelines refers to a new README template in the wiki in this repo.
I made a few small related changes:
Collaborator-Guide.mdsince the TC adopted this as our style, but it was not mentioned anywhere.Contributing.mdto remove text carried over from Node.js project, and make it more specific to Express.js project, plus some minor wording edits.@expressjs/express-tc