Update package.json#3249
Closed
ravirasadiya wants to merge 1 commit intoexpressjs:masterfrom
ravirasadiya:patch-2
Closed
Update package.json#3249ravirasadiya wants to merge 1 commit intoexpressjs:masterfrom ravirasadiya:patch-2
ravirasadiya wants to merge 1 commit intoexpressjs:masterfrom
ravirasadiya:patch-2
Conversation
now it's time to rename jade to pug
dougwilson
suggested changes
Mar 20, 2017
Contributor
dougwilson
left a comment
dougwilson
left a comment
There was a problem hiding this comment.
Hi @ravirasadiya it looks like all the builds are failing with this PR, because there is no version 2.0.0 of pug published to npm.
I also suspect that you would also have to change all our usages of jade to pug to be able to replace the dependency as well.
dougwilson
pushed a commit
that referenced
this pull request
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now it's time to rename jade to pug