Refactor: simplify req.acceptsEncodings with spread syntax #6139
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced use of `arguments` in `req.acceptsEncodings` with the spread syntax (`...encodings`) to improve readability and reduce code complexity, while maintaining the same functionality.
Contributor
|
already added #6086 |
Contributor
Author
Hello @Abdel-Monaam-Aouini Thanks for your input on this! I went with a slightly different approach to keep things concise by calling accepts(this).encodings(...encodings) directly, avoiding the intermediate accept variable. This makes the code a bit more streamlined and skips a minor, unnecessary allocation. I thought this might be more consistent with our style, but I’m happy to discuss if you see other benefits to your approach! |
wesleytodd
requested changes
Nov 15, 2024
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
We need to have a discussion for this one on if we would want to merge without some performance testing. Just adding this block so assess that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced use of
argumentsinreq.acceptsEncodingswith the spread syntax (...encodings) to improve readability and reduce code complexity, while maintaining the same functionality.