refactor(cookie): remove cookie-signature dependency and use the native crypto module to sign cookie#6175
Closed
bhavya3024 wants to merge 0 commit intoexpressjs:masterfrom
Closed
refactor(cookie): remove cookie-signature dependency and use the native crypto module to sign cookie#6175bhavya3024 wants to merge 0 commit intoexpressjs:masterfrom
cookie-signature dependency and use the native crypto module to sign cookie#6175bhavya3024 wants to merge 0 commit intoexpressjs:masterfrom
Conversation
bhavya3024
changed the title
cookie-signature dependency and use the native crypto module to sign cookie
wesleytodd
requested changes
Nov 13, 2024
Member
There was a problem hiding this comment.
My main concern with this is if the ecosystem of middleware is using cookie-signature to sign their own cookies that can then be read by express, this means we can no longer rely on it all working the same as we update in the future. I am going to request changes for now just to ensure we address that before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cookie-signaturedependency is not required since it itself uses thecryptomodule to sign cookies itself.You can check here: https://github.com/tj/node-cookie-signature/blob/master/index.js