Upgrade content-type#7234
Open
blakeembrey wants to merge 1 commit into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only used in
express/lib/utils.js
Lines 225 to 238 in f873ac2
content-typeheaders asparseno longer fails but instead does its best, but theformatbelow it will validate anything that was parsed.This only leaves edge cases like unterminated
"or trailing content after""xyzas omitted. 100% backward compatibility can be achieved for these edge cases if its wanted, but I'm not sure it's worth it.Version 2 of
content-typewas focused on performance and since this is the only method in the package using it, it's not a critical upgrade and would only serve to deduplicate with any dependencies that also upgrade.