-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Replace Google Font with local variable font #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Google Font with local variable font #1910
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unused font files and folders. Also add local font names for all fonts, see suggestions below.
I tried to find the
fontsource-variablefonts foropen-sansbut I was not able to find
You can use variable fonts from this repo. This will solve the problem with woff file size. See fontsource/fontsource#773 for more info.
ShubhamOulkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove ttf folder and rename font files.
ShubhamOulkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 manually tested on Firefox and Chrome. Fonts are correctly applied and rendering as expected.
Thanks @utkarsh125, for the changes.
|
Thank you @ShubhamOulkar for pointing out mistakes and guiding me on how to fix them. It was a good learning experience for me, hope to contribute more in the future :D |
bjohansebas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShubhamOulkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
thanks @utkarsh125 |
|
You're welcome @bjohansebas looking forward to contributing more in future :D |

fixes: #1750
I have installed
fontsourceOpen Sans and removed the script link for Google's Open Sans as discussed in the issue.Packages installed
If any more changes are needed I would be happy to make changes