build: pin stable Rust version via rust-toolchain.toml#481
Merged
Conversation
|
Code coverage summary for 7d7f1f5: ✅ Region coverage 69% passes |
The stable Rust version lived only in the Earthfile's base image tag. Local builds were left unpinned, and the nix flake floated on rust-overlay's latest stable, so the three could silently drift onto different compilers. Add a rust-toolchain.toml that rustup honours for both local builds and the Earthfile image, and pin the nix stable toolchain to that same channel (rustLatest -> rustStable) rather than tracking latest. The nightly updater now rewrites the toml alongside the Earthfile and refreshes the rust-overlay input in flake.lock, so nix can resolve the freshly pinned version within the same PR.
kp-thomas-yau
force-pushed
the
add-rust-toolchain-toml
branch
from
July 21, 2026 08:29
163a2eb to
550a81d
Compare
kp-thomas-yau
marked this pull request as ready for review
July 21, 2026 08:50
kp-anuz-tomar
approved these changes
Jul 21, 2026
kp-anuz-tomar
left a comment
kp-anuz-tomar
left a comment
Contributor
There was a problem hiding this comment.
I don't see anything here which looks out of place. Seems like regular update stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The stable Rust version lived only in the Earthfile's base image tag. Local builds were left unpinned, and the nix flake floated on rust-overlay's latest stable, so the three could silently drift onto different compilers.
Add a rust-toolchain.toml that rustup honours for both local builds and the Earthfile image, and pin the nix stable toolchain to that same channel (rustLatest -> rustStable) rather than tracking latest. The nightly updater now rewrites the toml alongside the Earthfile and refreshes the rust-overlay input in flake.lock, so nix can resolve the freshly pinned version within the same PR.
Motivation and Context
Earthly, local build and nix build uses the same rust compiler
How Has This Been Tested?
Passed CI and tested building lightway-client/core locally
Types of changes
Checklist:
main