Array btreemap conversion

[kakserpom]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 16353578993

Details

• 0 of 18 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 24.494%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/types/array.rs	0	18	0.0%

Totals
Change from base Build 16353567988:	-0.1%
Covered Lines:	968
Relevant Lines:	3952

---

💛 - Coveralls

[Xenira]

@kakserpom thank you <3

Just some things:

1. Could you please use the MR template. It is there for a reason. No need to add a description when referencing an issue, but it serves as a reminder for both the author and the reviewer on what to check.
2. Could you split this in 2 MRs, as these are 2 unrelated features
3. Unit and integration tests are missing.
4. At least the BTreeMap would benefit from being mentioned in the guides
5. cargo fmt fails. We have git hooks that could catch that if you want to use them :)

[kakserpom]

@Xenira Sure, now it's split into two MRs. I don't believe there's anything to test.

[Xenira]

Think having unit and integration tests is an easy win here.

Can add them myself if you like.

[Xenira]

Can we do this here? Same for the others.

Suggested change

	impl<'a, V> TryFrom<&'a ZendHashTable> for BTreeMap<String, V>
	where
	V: FromZval<'a>,
	{
	impl<'a, K, V> TryFrom<&'a ZendHashTable> for BTreeMap<K, V>
	where
	K: TryFrom<ArrayKey<'a>, Error = Error>,
	V: FromZval<'a>,
	{

[kakserpom]

@Xenira Not sure this is a good idea.

[ptondereau]

hey! we split array.rs into smaller files. You can rebase and create a dedicated src/types/array/conversions/btreemap.rs

[kakserpom]

#535