feat(array): introducing BTreeMap conversion and refactoring HashMap conversion

[kakserpom]

Description

I've added the same FromZval/IntoZval conversions for BTreeMap that exist for HashMap.

I know a doc update wouldn't hurt, but I am too preoccupied with development atm.

[coveralls]

Pull Request Test Coverage Report for Build 16812403437

Details

• 33 of 57 (57.89%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 27.673%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/types/array/conversions/btree_map.rs	25	27	92.59%
src/types/array/conversions/hash_map.rs	0	3	0.0%
src/types/array/array_key.rs	6	10	60.0%
src/types/array/mod.rs	2	17	11.76%

Totals
Change from base Build 16812389301:	0.5%
Covered Lines:	1149
Relevant Lines:	4152

---

💛 - Coveralls

[ptondereau]

LGTM but would it be possible to have some tests?

[Xenira]

Also could you elaborate on this? #520 (comment)

[kakserpom]

@Xenira

Also could you elaborate on this? #520 (comment)

I've implemented your suggestion. I've also fixed the cause of clippy::implicit_hasher warning in hash_map by generalizing the hasher.

[kakserpom]

LGTM but would it be possible to have some tests?

What's there to test? Rustc does the job pretty well :)

[ptondereau]

LGTM but would it be possible to have some tests?

What's there to test? Rustc does the job pretty well :)

Just ensuring the conversion if it makes sense

[kakserpom]

I've changed the behavior of impl TryFrom<ArrayKey<'_>> for String. Now it converts numeric keys into strings, instead of giving an error.

[kakserpom]

And also I've moved the code that treats numeric string keys as long, now it happens in ArrayKey conversion impls. So no more boilerplate in impl ZendHashTable.

[Xenira]

I've changed the behavior of impl TryFrom<ArrayKey<'_>> for String. Now it converts numeric keys into strings, instead of giving an error.

You are probably right. This would indeed be the desired behaviour for TryFrom.

And also I've moved the code that treats numeric string keys as long, now it happens in ArrayKey conversion impls. So no more boilerplate in impl ZendHashTable.

This has some implications on types and I don't like how much we implicitly convert string and int values. But that is an issue for later.