feat: Add reusable UI components for settings improvements (PR #1/8)#67
Merged
Conversation
Add three new SwiftUI components to support settings UI refactoring: - KeyValueEditor: Unified editor for environment variables and tags - Configurable secret toggle and validation - Full-width inputs with proper alignment - Supports both .environmentVariables and .tags configurations - PathInputField: Two-line path input with browse button - Optional path validation with warning indicators - Consistent monospaced styling - Pre-selects current path in file browser - StatusIndicator: Reusable status line component - Icon + descriptive text + colored status indicator - Multiple states: active, ready, installed, disabled, inactive, error - Consistent styling for feature/service state display All components conform to Swift Sendable protocol for concurrency safety. Part of settings UI improvements initiative (PR #1 of 8). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Auto-format PathInputField and StatusIndicator to fix: - Import statement ordering - Line breaks for long lines - Indentation consistency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR #1 of 8 in the settings UI improvements initiative. This PR adds foundational reusable SwiftUI components that will be used in subsequent PRs to refactor and improve the settings UI.
Components Added
1. KeyValueEditor
.environmentVariablesand.tagsconfigurations2. PathInputField
3. StatusIndicator
Technical Details
Sendableprotocol for concurrency safetyTesting
Implementation Plan
This is part of an 8-PR incremental delivery strategy:
Checklist
🤖 Generated with Claude Code