fix: switch to new terminal after creation#3
Merged
Conversation
- Add "Switch to new terminal" toggle in new terminal dialog (checked by default) - Track whether card being edited is new vs existing - Automatically switch to new terminal when toggle is enabled - Change dialog title to "New Terminal" vs "Edit Terminal" based on context Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 18, 2026
eyelock
added a commit
that referenced
this pull request
Jan 18, 2026
* feat: integrate KeyValueEditor in environment tabs Apply shared KeyValueEditor component to both Settings > Environment and Terminal Details > Environment tabs for consistent UI and behavior. Changes: - Settings Environment tab: Replace inline form with KeyValueEditor - Terminal Details Environment tab: Replace inline editor with KeyValueEditor - Both tabs now use identical shared component with full-width inputs - Consistent styling with Form .formStyle(.grouped) - Proper state synchronization between KeyValueItem and EnvironmentVariable Addresses feedback #4, #7, #8, #9, #11 from implementation plan Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * feat: improve environment settings UI with component split and fixes Split KeyValueEditor into focused components (KeyValueList + KeyValueAddForm) for better UX with separate sections for viewing and adding items. Changes: - Split KeyValueEditor.swift into 3 components: * KeyValueList - display existing items with delete * KeyValueAddForm - add new items with validation * KeyValueEditor - legacy wrapper (deprecated) - SettingsEnvironmentView improvements: * Use split components in separate sections * Add proper error handling with user-visible alerts * Fix encryption key status race condition * Remove nested Form wrapper - CardEditorEnvironmentTab improvements: * Use split components in separate sections * Add secret visibility toggle for inherited globals * Add proper error handling with alerts * Store secret values in memory for display - Add localized section headers: * "Global Environment Variables" * "Add Environment Variable" (Settings) * "Add Environment Variable" (Terminal Details) Fixes: - Secrets not being added (silent error swallowing with try?) - Encryption key status not updating after operations - Secret values not viewable in Terminal Details inherited list Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: David Collie <support@eyelock.net> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
10 tasks
eyelock
pushed a commit
that referenced
this pull request
Jan 18, 2026
…/8) Apply reusable UI components from PRs #1-2 to Terminal settings tab, improving consistency and user experience across settings interfaces. Changes: - Replace Working Directory TextField+Button with PathInputField component - Adds path validation with warning icon for invalid paths - Provides consistent folder browser experience - Replace three security toggle patterns with SharedToggle component: - "Allow Agent Prompts" (renamed from "Allow Autorun" for clarity) - "Confirm External Modifications" - "Allow OSC Clipboard" - Update AppStorage keys to match global settings from PR #2: - enableTerminalAutorun → globalAllowAgentPrompts - confirmExternalLLMModifications → globalAllowExternalModifications - Added globalAllowOscClipboard - Reorder security toggles to match Global Settings order for consistency - Add localization strings for Agent Prompts and disabled messages - Fix line length warnings in Strings.swift Technical details: - Removed obsolete browseDirectory() function (handled by PathInputField) - Consistent disabled messaging when global settings are off - Matches visual patterns established in Environment tab (PR #3) - All security toggles now use unified SharedToggle component - Added translations to all 40 language files Part of Settings UI improvement series (PR #5 of 8) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
eyelock
added a commit
that referenced
this pull request
Jan 18, 2026
…/8) (#73) Apply reusable UI components from PRs #1-2 to Terminal settings tab, improving consistency and user experience across settings interfaces. Changes: - Replace Working Directory TextField+Button with PathInputField component - Adds path validation with warning icon for invalid paths - Provides consistent folder browser experience - Replace three security toggle patterns with SharedToggle component: - "Allow Agent Prompts" (renamed from "Allow Autorun" for clarity) - "Confirm External Modifications" - "Allow OSC Clipboard" - Update AppStorage keys to match global settings from PR #2: - enableTerminalAutorun → globalAllowAgentPrompts - confirmExternalLLMModifications → globalAllowExternalModifications - Added globalAllowOscClipboard - Reorder security toggles to match Global Settings order for consistency - Add localization strings for Agent Prompts and disabled messages - Fix line length warnings in Strings.swift Technical details: - Removed obsolete browseDirectory() function (handled by PathInputField) - Consistent disabled messaging when global settings are off - Matches visual patterns established in Environment tab (PR #3) - All security toggles now use unified SharedToggle component - Added translations to all 40 language files Part of Settings UI improvement series (PR #5 of 8) Co-authored-by: David Collie <support@eyelock.net> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
isNewCardparameter andswitchToTerminaltoggleisEditingNewCardstate to track new vs existing cardsTest plan
make clean app🤖 Generated with Claude Code