feat: Add SharedToggle component and reorganize settings tabs (PR #2)

[eyelock]

Summary

Implements PR #2 from the settings UI improvement plan:

• Creates SharedToggle component for consistent global/local setting UX
• Reorganizes General and Data & Security tabs for better user flow
• Updates security settings with safer defaults (all FALSE)

Changes

New Component: SharedToggle

• Reusable toggle that respects global settings
• Shows disabled state with optional clickable message to settings
• Supports help text and custom disabled messages
• Will be used extensively in PRs docs: add keyboard shortcuts and pinned terminals to README #5 and feat: add quick new terminal button to focused terminal toolbar #6 for terminal-level settings

General Tab Reorganization

New section order:

1. Terminal (theme, copy on select, default working directory, default backend)
2. Bin (retention days, empty bin button)
3. Updates (auto-check, beta releases, check now button)
4. Language (language picker)
5. Uninstall (moved from Data & Security)
6. About (version, build)

Rationale: Puts most frequently used settings at top, moves destructive action to end

Data & Security Tab Reorganization

New section order:

1. Security (3 toggles: agent prompts, external modifications, OSC clipboard)
2. Data Storage (data directory with browse button)
3. Data Protection (BackupSettingsView)

Rationale: Security settings at top as they're critical, followed by data management

Security Settings Updates

• New: allowTerminalsToRunAgentPrompts (default: false)
  • Global setting to enable terminal-level agent prompt execution
  • Will gate terminal-specific toggle in PR feat: add quick new terminal button to focused terminal toolbar #6
• Renamed: confirmExternalLLMModifications → allowExternalLLMModifications
  • Clearer naming to indicate this is a permission, not just confirmation
• Changed defaults: All security settings now default to FALSE (more secure)
  • allowTerminalsToRunAgentPrompts: false
  • allowExternalLLMModifications: false
  • allowOscClipboard: false

Implementation Notes

Localization

Proper localization for new strings (allowTerminalsToRunAgentPrompts) will be added in PR #7.
For now, using placeholder string "Allow Terminals to run Agent Prompts".

Expected Warnings

SwiftLint reports file_length (535 lines) and type_body_length (409 lines) violations in SettingsView.swift.
These are expected and will be resolved in PR #7 when we extract sections into dedicated views.

Testing

• ✅ All builds pass with zero errors
• ✅ All tests pass (521 tests)
• ✅ Formatting verified with make format
• ✅ Only expected length warnings in SettingsView.swift

Next Steps

• PR fix: switch to new terminal after creation #3: Integrate Environment components into SettingsEnvironmentView
• PR feat: add keyboard shortcuts for terminal management #4: Add KeyValueEditor for terminal environment variables and tags
• PR docs: add keyboard shortcuts and pinned terminals to README #5: Add PathInputField and SharedToggle to terminal editor
• PR feat: add quick new terminal button to focused terminal toolbar #6: Complete Agent tab overhaul with all new components
• PR fix: add pin toggle to board view and fix terminal CWD switching #7: Final polish, localization, and view extraction

🤖 Generated with Claude Code

[claude]

Code Review

Issues Found

1. 🌍 Hardcoded UI Strings Not Localized

Location: Sources/TermQ/Views/SettingsView.swift:315-316

Two hardcoded English strings that should use the Strings localization system:

Toggle("Allow Terminals to run Agent Prompts", isOn: $allowTerminalsToRunAgentPrompts)
    .help("Allow terminals to execute prompts from agent context (global setting)")

Issue: These strings will not be translatable to the 40+ supported languages.

Reference: CLAUDE.md localization requirements requires all UI strings to use the Strings.* pattern (see localization.md).

Pattern: All other settings in this file correctly use Strings.Settings.*:

• Line 318: Strings.Settings.confirmExternalModifications
• Line 321: Strings.Settings.allowOscClipboard

Fix: Add these strings to the Strings.Settings enum and localize them.

---

2. 🌍 Hardcoded Default Parameter in SharedToggle

Location: Sources/TermQ/Views/Components/SharedToggle.swift:34

disabledMessage: String = "Disabled globally",

Issue: This user-facing default parameter value is a hardcoded English string that won't be translated.

Reference: CLAUDE.md localization requirements requires all user-facing strings to be localized.

Fix: Either remove the default and require callers to provide localized strings, or use a localized reference like Strings.Settings.disabledGlobally.

---

3. 🐛 AppStorage Key Mismatch

Location: Sources/TermQ/Views/SettingsView.swift:43

@AppStorage("allowExternalLLMModifications") private var allowExternalLLMModifications = false

Issue: The PR renames the key from "confirmExternalLLMModifications" to "allowExternalLLMModifications", but other files still use the old key:

• CardEditorView.swift:37 - uses "confirmExternalLLMModifications"
• TermQApp.swift:15,21,24,27 - uses "confirmExternalLLMModifications"

Impact: Settings changes in SettingsView will NOT affect the actual behavior in CardEditorView and TermQApp because they're reading from different UserDefaults keys. The UI toggle will appear broken.

Fix: Update CardEditorView.swift and TermQApp.swift to use the new key name, or revert this change and rename in a coordinated way across all files.

---

4. 🐛 Conflicting Default Values for allowOscClipboard

Location: Sources/TermQ/Views/SettingsView.swift:44

@AppStorage("allowOscClipboard") private var allowOscClipboard = false

Issue: This PR changes the default from true to false, but CardEditorView.swift:36 still has true as the default for the same key.

Impact: The effective default depends on which view loads first, causing unpredictable behavior for a security-related setting.

Fix: Update CardEditorView.swift:36 to also use false as the default value to maintain consistency.

---

Summary

Found 4 issues:

• 2 localization violations (hardcoded UI strings)
• 2 bugs (AppStorage key mismatch and conflicting defaults)

All issues should be addressed before merging to maintain code quality and prevent runtime bugs.