feat: apply PathInputField and SharedToggle to Terminal settings (PR #5/8)#73
Merged
Conversation
…/8) Apply reusable UI components from PRs #1-2 to Terminal settings tab, improving consistency and user experience across settings interfaces. Changes: - Replace Working Directory TextField+Button with PathInputField component - Adds path validation with warning icon for invalid paths - Provides consistent folder browser experience - Replace three security toggle patterns with SharedToggle component: - "Allow Agent Prompts" (renamed from "Allow Autorun" for clarity) - "Confirm External Modifications" - "Allow OSC Clipboard" - Update AppStorage keys to match global settings from PR #2: - enableTerminalAutorun → globalAllowAgentPrompts - confirmExternalLLMModifications → globalAllowExternalModifications - Added globalAllowOscClipboard - Reorder security toggles to match Global Settings order for consistency - Add localization strings for Agent Prompts and disabled messages - Fix line length warnings in Strings.swift Technical details: - Removed obsolete browseDirectory() function (handled by PathInputField) - Consistent disabled messaging when global settings are off - Matches visual patterns established in Environment tab (PR #3) - All security toggles now use unified SharedToggle component - Added translations to all 40 language files Part of Settings UI improvement series (PR #5 of 8) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies reusable UI components from PRs #1-2 to Terminal settings tab, improving consistency and user experience across settings interfaces.
Changes
PathInputField for Working Directory
SharedToggle for Security Settings
Replaced three manual toggle patterns with SharedToggle component:
All toggles now:
Technical Updates
browseDirectory()function (handled by PathInputField)Testing
✅ PathInputField: Path validation, folder browser, invalid path warnings
✅ SharedToggle: All three security toggles use consistent component
✅ Global gates: Toggles disable correctly when global setting is off
✅ State persistence: Toggle states save and restore correctly
✅ Visual consistency: Order matches Global Settings
✅ All 521 tests pass
Screenshots
Terminal Details > Security section now matches Global Settings order and uses SharedToggle pattern.
Part of Settings UI improvement series (PR #5 of 8)
🤖 Generated with Claude Code