Skip to content

EZEE-3506: Added data for SiteFactory setup - #177

Merged
mnocon merged 1 commit into
8.3from
add-sitefactory-setup
May 6, 2021
Merged

EZEE-3506: Added data for SiteFactory setup#177
mnocon merged 1 commit into
8.3from
add-sitefactory-setup

Conversation

@mnocon

@mnocon mnocon commented Mar 23, 2021

Copy link
Copy Markdown
Member

JIRA: https://issues.ibexa.co/browse/EZEE-3506

Required by:
https://github.com/ezsystems/ezplatform-site-factory/pull/116

Things done:

  1. ConfigurationEditor is now a bit smarter:
    you can use a special %location_id(itemLocationURL)% function which will be resolved to the location_id of the specified item.

Example:

  Scenario Outline: Configure Site Factory siteaccesses
    Given I append configuration to "ez_platform_site_factory.templates" in "config/packages/ezplatform_site_factory.yaml"
    """
          <template_id>:
            siteaccess_group: <sa_group>
            name: <template_name>
            thumbnail: https://placekitten.com/500/500
            site_skeleton_id: "%location_id(Site-skeletons/MySiteSkeleton)%"
    """

The site_skeleton_id value will be set to the Location ID of the /Site-skeletons/MySiteSkeleton item. No need for hardcoding IDs 😄

  1. Added Twig templates required by https://github.com/ezsystems/ezplatform-site-factory/pull/116 (more description there).

@mnocon
mnocon marked this pull request as ready for review March 24, 2021 14:47

Assert::assertEquals(['testKey' => [2, 5]], $config);
}
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an empty line at the end of the file

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled and fixed CS for tests in 9825288

@mnocon
mnocon changed the base branch from master to 8.3 May 6, 2021 14:04
@mnocon
mnocon force-pushed the add-sitefactory-setup branch from c38a449 to 68eeb89 Compare May 6, 2021 14:36
@mnocon
mnocon merged commit 7bf2c04 into 8.3 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants