Added ability to update stars rating outside the component - #9
Closed
fighterinthewind wants to merge 2 commits into
Closed
Added ability to update stars rating outside the component#9fighterinthewind wants to merge 2 commits into
fighterinthewind wants to merge 2 commits into
Conversation
f0rr0
reviewed
Jul 19, 2018
|
|
||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| this.animate(nextProps.initial, false)() |
Owner
There was a problem hiding this comment.
calling setState here should be enough ?
Author
There was a problem hiding this comment.
No, it should not be enough.
It works exactly how I implemented it.
Owner
|
Thanks for contributing this. Closing because the current v4 API now supports explicit controlled usage with value plus onChange and uncontrolled usage with defaultValue. This patch targets the removed src/rating.js and conflicts with master; the componentWillReceiveProps implementation also resets and reanimates from initial on every parent update, even when that value is unchanged. The original use case is covered by the current API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.