Updated to allow specifying Cosmos Db partition key path#6
Merged
f1x3d merged 3 commits intoAug 29, 2024
Merged
Conversation
Contributor
Author
|
My apologies, I should have made this backwards compatible to default to '/pk' for any existing users. If you think this PR has merit let me know and I can continue implement that. Or if you have suggestions on how to best do so, I'm open to that as well. |
f1x3d
reviewed
Aug 29, 2024
f1x3d
left a comment
f1x3d
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! I like the idea, please feel free to proceed with the changes
…ious version of the extension methods and also the default value of `/pk` for the partition key path.
f1x3d
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to allow the partition key to be variable in the same manner as the DatabaseName and ContainerName. In many cases users will not have the partition key as /pk and they should be able to use an alternative value.