Skip to content

Apply review fixes for keypaths separator handling#585

Merged
fabiocaccamo merged 4 commits into
mainfrom
copilot/fix-code-comments
Jul 7, 2026
Merged

Apply review fixes for keypaths separator handling#585
fabiocaccamo merged 4 commits into
mainfrom
copilot/fix-code-comments

Conversation

Copilot AI commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Describe your changes
Address the review-thread feedback on keypaths() separator validation and test coverage. This updates the separator contract so None preserves the default "." behavior while "" remains invalid.

  • Validation logic

    • Default separator only when separator is None
    • Reject empty-string separators explicitly with the existing ValueError
  • Test coverage

    • Replace the implicit default-case test with an explicit separator=None assertion
    • Keep coverage focused on the reviewed behavior only
if separator is None:
    separator = "."
if not type_util.is_string(separator) or len(separator) == 0:
    raise ValueError("separator argument must be a (non-empty) string.")

Related issue
Addresses the review comments in the linked PR review thread.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (9120d48) to head (c248664).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          64       64           
  Lines        2392     2393    +1     
=======================================
+ Hits         2352     2353    +1     
  Misses         40       40           
Flag Coverage Δ
unittests 98.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI changed the title [WIP] Fix code based on review comments Apply review fixes for keypaths separator handling Jul 7, 2026
Copilot AI requested a review from fabiocaccamo July 7, 2026 10:54
@fabiocaccamo fabiocaccamo marked this pull request as ready for review July 7, 2026 12:31
@fabiocaccamo fabiocaccamo merged commit c7c934f into main Jul 7, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants