Repl target fix#1065
Conversation
ncave
commented
Jul 12, 2017
- Repl target fix
- downgraded reraise level from error to warning
|
Great @ncave, thank you! I think we may start creating a JS-only FCS/Fable package. I think I've asked you like a million times but the responses get lost in the issue labyrinth: so can we add the FCS files from your fork as a github dependency? Is the Fslex step still needed? Where should we put the needed dlls? As you suggested before, maybe we should create a new repo for the REPL/JS package and make self-buildable without external dependencies on the system to make it easier for starting contributors? |
|
@alfonsogarciacaro Sure, you can add a paket github dependency to FCS-fable, it's going to bloat Fable somewhat but I guess that's ok. Unfortunately the fslexyacc step is still needed as there is no netcore tooling for that and I see no plans for it (even though it should be fairly easy to port it now with netstandard 2.0). We already have the dlls in the github pages, so they can be paket referenced from there, or somewhere else. On the other hand, if we flip this around, all this does not need to happen in Fable, it can (and should) be in a separate repo. I was suggesting starting a new repo that can have all that and also paket-reference Fable Core and Fable Compiler for the source. I have a proto repo called fable-repl, for now it just has the monaco bindings. If you agree, I can transfer its ownership to the fable-compiler org and we continue the work there. The old repl can stay in Fable until the new one is operational, to minimize throw-away effort. Let me know what you think is the best way forward. |
|
Absolutely, I think that's a great idea! Can you please transfer the ownership of the repo and we can continue work there? Thanks a lot! |
|
@alfonsogarciacaro Done. To clarify, I still think you're right to push for a JS-only FCS/Fable package, so it can be used not only by the fable-repl but other repls too. Which repo that belong into, this is the question - fable, fable-repl or a new one, say fable-js. |
|
I think it's should not belongs to fable-repl as it's not explicit that user could use JS-only FCS/ from it. Personally, I tend in favor of fable-js |
Fix code scanning alerts IONIDE-009 (alerts #1056-#1058, #1069-#1070, #1083) and IONIDE-002 (alerts #1065, #1072, #1181). - Add [<return: Struct>] to partial active patterns in BabelPrinter.fs and Python transforms to avoid heap allocation for option types - Replace [] postfix array syntax with the idiomatic 'array' postfix syntax in BabelPrinter.fs, Fable2Python.Util.fs, and Python.AST.fs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>