Skip to content

Culture invariant tests#2600

Merged
alfonsogarciacaro merged 1 commit intofable-compiler:mainfrom
kerams:tests-culture
Nov 11, 2021
Merged

Culture invariant tests#2600
alfonsogarciacaro merged 1 commit intofable-compiler:mainfrom
kerams:tests-culture

Conversation

@kerams
Copy link
Copy Markdown
Contributor

@kerams kerams commented Nov 10, 2021

Fixes #2597.

I used Replace in some places because with InvariantCulture Mocha tests started failing with ToString producing unexpected different results.

@alfonsogarciacaro
Copy link
Copy Markdown
Member

alfonsogarciacaro commented Nov 11, 2021

Thanks! We may need to fix ToString with CultureInfo in Fable but we can open a separate issue for that 👍

@alfonsogarciacaro alfonsogarciacaro merged commit eb2056a into fable-compiler:main Nov 11, 2021
@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Nov 11, 2021
Open
@kerams kerams deleted the tests-culture branch November 11, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fable .NET tests are dependent on the system locale

2 participants

@kerams @alfonsogarciacaro