Skip to content

[CI] Fix analyzer failures by restricting SDK rollForward policy#4457

Merged
ncave merged 2 commits intomainfrom
fix/global-json-rollforward
Mar 28, 2026
Merged

[CI] Fix analyzer failures by restricting SDK rollForward policy#4457
ncave merged 2 commits intomainfrom
fix/global-json-rollforward

Conversation

@dbrattli
Copy link
Copy Markdown
Collaborator

@dbrattli dbrattli commented Mar 28, 2026

Summary

  • The GitHub runner image was updated (~March 27) to include .NET SDK 10.0.201 (a newer feature band). With "rollForward": "latestMajor" in global.json, the runtime used this newer SDK which ships FSharp.Core 10.1.201 (FSharp.Core version is decoupled from SDK version)
  • The fsharp-analyzers tool (v0.36.0) requires FSharp.Core = 10.0.101, and the 10.0→10.1 jump causes it to silently crash at runtime (the MSBuild target has ContinueOnError=true and IgnoreExitCode=true)
  • No SARIF reports are generated, so the upload-sarif step fails with Path does not exist: src/reports
  • Changed rollForward from "latestMajor" to "latestPatch" — this stays within the 10.0.1xx feature band where FSharp.Core remains at 10.0.x. (latestFeature was also tried but still rolled forward to SDK 10.0.201 which ships FSharp.Core 10.1.201)

Test plan

  • Verify the analyzers CI jobs pass on this PR
  • Verify other CI jobs (build-javascript, build-python, etc.) are not affected by the rollForward change

🤖 Generated with Claude Code

dbrattli and others added 2 commits March 28, 2026 10:04
The GitHub runner image was updated to include .NET SDK 10.1.x, and
latestMajor rollForward caused FSharp.Core 10.1.201 to be resolved
instead of 10.0.x. This broke the fsharp-analyzers tool (which requires
FSharp.Core = 10.0.101) causing silent crashes and missing SARIF reports.

latestFeature stays within 10.0.x while still allowing feature band updates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
latestFeature still rolled forward to SDK 10.0.201, which ships
FSharp.Core 10.1.201 (decoupled from SDK version). latestPatch
restricts to the 10.0.1xx band where FSharp.Core is 10.0.x.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dbrattli dbrattli changed the title chore: Fix CI analyzer failures by restricting SDK rollForward policy [CI] Fix analyzer failures by restricting SDK rollForward policy Mar 28, 2026
@dbrattli dbrattli requested review from MangelMaxime and ncave March 28, 2026 09:21
@ncave ncave merged commit 326c3b1 into main Mar 28, 2026
24 checks passed
@ncave ncave deleted the fix/global-json-rollforward branch March 28, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants