fix(js/ts): hex format specifier uses no padding unless precision is specified#4603
Merged
MangelMaxime merged 1 commit intoMay 14, 2026
Merged
Conversation
MangelMaxime
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was updating from v4.29.0 to v5.0.0 and noticed a change in behavior with formatting numbers to hex with no precision defined.
When converting to hex that should be single digit with no precision defined, v5.0.0 started left padding with a "0". This PR makes it so there's no left padding anymore to align with .NET's behavior.
Repro in REPL here, and you can copy/paste the code in to
dotnet fsito see that the output is different.If you'd like anything adjusted/modified or if you'd like for me to create an issue first, please let me know. Thank you for everything Fable, and thank you for your time!