chore: fetch tags so PyPI publish resolves the real version#4668
Merged
Conversation
The build-fable-library job runs `dunamai ... --latest-tag` to derive the package version, but actions/checkout defaults to a shallow clone with no tags. dunamai then found no tag and fell back to its default 0.0.0, which got published to PyPI. Use fetch-depth: 0 so the full tag history is available. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dbrattli
changed the title
dbrattli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A manually triggered PyPI publish shipped version 0.0.0 to PyPI (https://pypi.org/project/fable-library/0.0.0/).
Root cause
The
build-fable-libraryjob derives the package version with:VERSION=$(dunamai from git --format "..." --pattern "..." --latest-tag)actions/checkoutdefaults to a shallow clone (fetch-depth: 1) that does not fetch tags. With no tags available,dunamai --latest-tagfalls back to its default base version0.0.0, which then gets built into the wheels and published.Fix
Set
fetch-depth: 0on the checkout in thebuild-fable-libraryjob so the full tag history is available anddunamairesolves the actual release version. Only this job runsdunamai— the wheel-building jobs just download the produced artifact — so no other checkout needs changing.🤖 Generated with Claude Code