Skip to content

Conversation

@ncave
Copy link
Collaborator

@ncave ncave commented Apr 29, 2017

  • added Rollup config to Tests, seems to work.
  • added Rollup config to REPL, seems to work.
  • added a check cmd to try the new --checkJs option in typescript 2.3
    cd src/tests / npm run fable / npm run rollup / npm run test / npm run check

@ncave ncave force-pushed the master branch 2 times, most recently from 37b7dc8 to e65487f Compare April 29, 2017 08:29
@alfonsogarciacaro
Copy link
Member

Thanks!

@alfonsogarciacaro alfonsogarciacaro merged commit 32f9ed0 into fable-compiler:master May 2, 2017
@ncave
Copy link
Collaborator Author

ncave commented May 2, 2017

@alfonsogarciacaro Thanks for merging.
I've briefly looked at the result of type-checking the Fable output with typescript 2.3 --checkJs option:
cd src/tests / npm run fable / npm run rollup / npm run test / npm run check (ignore the error)
I don't see any major issues that need fixing, but still it looks like a valuable tool for validating the Fable output without having to go the TypeScript AST way.

@ncave ncave mentioned this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants