Skip to content

Conversation

@beberlei
Copy link

It seems i introudced a bug while doing the merge refactoring. I increased coverage for this scenario.

However I came across a weird case, and that is if i have the "orm_imports.xml" config which imports the "orm_imports_import.xml", then DoctrineExtension::ormLoad($configs) is passed the dev/prod configuration first and the "default" configuration second.

For a useful overwriting mechanism this would mean I have to array_reverse these values.

Is this intended?

@fabpot
Copy link
Owner

fabpot commented Jan 24, 2011

@beberlei
Copy link
Author

I will update this patch to include array_reverse() on the $configs, which is necessary for my algorithm to work correctly. I just foreach over the $configs now and iteratively build a $mergedConfig, which leads to wrong results.

…fig merge refactoring. Use array_reverse() for $configs to fix incremental merge algorithm assumptions.
@beberlei
Copy link
Author

I have redone the patch, this is now it. I will add a more complex merge config scenario so that this problem will not occour again this week.

@beberlei
Copy link
Author

Oh please merge this, people are going to complain about proxy generation not working anymore in dev mode :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants