Improve Auxillary Exp check #4824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Confirmed that this repr is unique enough, the only time it would not be unique enough is if two criteria exist on a node and are exactly equal in all fields, which is a malformed state Reviewed By: saitcakmak Differential Revision: D91011862
Summary: Instead of fetching data we should use lookup for performance reasons. Reviewed By: saitcakmak Differential Revision: D91011958
…acebook#4802) Summary: Instead of merely checking for presence of any data, we could unify this transition with the helper method we use in target trial logic. This will allow us to check that all metrics in the opt config have data before transitioning, which also ensures target trial selection is correct once we are in mbm etc. We could add additional checks about amount of data, but i think this is a good start. Happy to hear other thougths Reviewed By: saitcakmak Differential Revision: D91064377
Summary: **Enforce `transition_to` as a required argument in `TransitionCriterion`** This diff makes `transition_to` a required argument in the `TransitionCriterion` class. It updates the `MinimumPreferenceOccurances` and `MinTrials` classes to include `transition_to` as a required argument. The `GenerationNode` class is also updated to include a `placeholder_transition_to` attribute, which will be overwritten in the `GenerationStrategy` constructor. The changes include: * Updated `MinimumPreferenceOccurances` and `MinTrials` classes to require `transition_to` argument * Added `placeholder_transition_to` attribute to `GenerationNode` class * Updated unit tests to reflect the changes With this change, users will be required to provide a `transition_to` argument when creating a `TransitionCriterion` object. This ensures that the `GenerationStrategy` knows which generation node to transition to when a criterion is met. Differential Revision: D91141100
Summary: This cleans up a todo from long ago, this is unique enough as it uses all components of a GeneratorSpec Reviewed By: saitcakmak Differential Revision: D91229383
Summary: After discussing with Jason Chow, AEPysch no longer interfaces with Ax, instead it directly leverages BoTorch. There are no plans atm to integrate directly with Ax, but if that is taken on in the future, it would be better to re-onboard them using GenNode based GSs given the opportunity for a clean slate. This allows us to remove special casing for AEPysch from GS codebase Reviewed By: saitcakmak Differential Revision: D91156800
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4824 +/- ##
==========================================
- Coverage 96.71% 96.71% -0.01%
==========================================
Files 586 585 -1
Lines 61320 61245 -75
==========================================
- Hits 59305 59231 -74
+ Misses 2015 2014 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 27, 2026
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC Differential Revision: D91365207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Some minor improvements to readabilty/ conciseness to the Auxillary exp TC
Differential Revision: D91365207