Preserve numeric contour arrays through Plotly serialization - #5278
Open
saitcakmak wants to merge 1 commit into
Open
Preserve numeric contour arrays through Plotly serialization#5278saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: Convert the contour trace `x`, `y`, and `z` values to plain Python lists before Plotly serialization. This prevents Plotly 6 from preserving NumPy-backed values as base64 typed-array dictionaries when `PlotlyAnalysisCard.get_figure()` reconstructs the figure. Differential Revision: D116474354
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116474354. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5278 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 621 621
Lines 70852 70867 +15
=======================================
+ Hits 68434 68449 +15
Misses 2418 2418 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Aug 18, 2026
…k#5278) Summary: Convert the contour trace `x`, `y`, and `z` values to plain Python lists before Plotly serialization. This prevents Plotly 6 from preserving NumPy-backed values as base64 typed-array dictionaries when `PlotlyAnalysisCard.get_figure()` reconstructs the figure. Fixes OSS CI failures caused by the previous diff. These didn't surface in internal infra due to different plotly versions used. Differential Revision: D116474354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Convert the contour trace
x,y, andzvalues to plain Python lists before Plotly serialization. This prevents Plotly 6 from preserving NumPy-backed values as base64 typed-array dictionaries whenPlotlyAnalysisCard.get_figure()reconstructs the figure.Differential Revision: D116474354