feat(types): add data-* index signature to XDSBaseProps - #1502
Merged
Conversation
Allows data-* attributes in object literal prop spreads, not just direct JSX usage. Fixes the TS2353 excess property check error when passing data-* keys through component prop objects (e.g. XDSDropdownMenu's button prop). Closes #1392 Co-authored-by: Navi <navi@navibot.dev>
meta-cla
Bot
added
the
CLA Signed
cixzhang
enabled auto-merge (squash)
April 19, 2026 18:30
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
added a commit
that referenced
this pull request
Apr 26, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
[key: \data-${string}`]: string | undefinedindex signature toXDSBaseProps, allowingdata-*` attributes in object literal prop spreads — not just direct JSX usage.Problem
TypeScript's JSX transform has special handling for
data-*attributes, but when constructing props as an object literal (e.g. passing thebuttonprop toXDSDropdownMenu), TS rejectsdata-*keys with TS2353 (excess property check).Fix
Narrow index signature that only allows
data-prefixed keys — no arbitrary props leak through.Closes #1392