fix(AppShell): match flex layout properties on sticky sidenav container - #1850
Merged
Conversation
When height='auto', the sidenav panel is wrapped in a sticky div that becomes the direct flex child of the middle (horizontal) container. This wrapper was missing the flex properties that XDSLayoutPanel applies (flexShrink: 0, overflow: clip), causing the flex container to potentially collapse the sidenav width. Changes: - Add flexShrink: 0 and overflow: clip to sideNavSticky (matching panel) - Remove alignSelf: 'stretch' (unnecessary — sticky height is explicit) - Move overflow: auto from the sticky wrapper to panelAutoFill so the panel itself scrolls within the fixed-height sticky container
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
2 tasks
cixzhang
added a commit
that referenced
this pull request
Apr 29, 2026
This was accidentally committed in #1850. It's a gitlink (mode 160000) with no corresponding .gitmodules entry.
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
…er (#1850) When height='auto', the sidenav panel is wrapped in a sticky div that becomes the direct flex child of the middle (horizontal) container. This wrapper was missing the flex properties that XDSLayoutPanel applies (flexShrink: 0, overflow: clip), causing the flex container to potentially collapse the sidenav width. Changes: - Add flexShrink: 0 and overflow: clip to sideNavSticky (matching panel) - Remove alignSelf: 'stretch' (unnecessary — sticky height is explicit) - Move overflow: auto from the sticky wrapper to panelAutoFill so the panel itself scrolls within the fixed-height sticky container
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This was accidentally committed in #1850. It's a gitlink (mode 160000) with no corresponding .gitmodules entry.
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
…er (#1850) When height='auto', the sidenav panel is wrapped in a sticky div that becomes the direct flex child of the middle (horizontal) container. This wrapper was missing the flex properties that XDSLayoutPanel applies (flexShrink: 0, overflow: clip), causing the flex container to potentially collapse the sidenav width. Changes: - Add flexShrink: 0 and overflow: clip to sideNavSticky (matching panel) - Remove alignSelf: 'stretch' (unnecessary — sticky height is explicit) - Move overflow: auto from the sticky wrapper to panelAutoFill so the panel itself scrolls within the fixed-height sticky container
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This was accidentally committed in #1850. It's a gitlink (mode 160000) with no corresponding .gitmodules entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
height='auto', the sidenav panel is wrapped in a sticky<div>that becomes the direct flex child of the middle (horizontal) container. This wrapper was missing the flex properties thatXDSLayoutPanelapplies (flexShrink: 0,overflow: clip), causing the flex container to potentially collapse the sidenav width.Changes:
flexShrink: 0andoverflow: cliptosideNavSticky(matching panel defaults)alignSelf: 'stretch'(unnecessary — sticky height is explicit viaheight: calc(...))overflow: autofrom the sticky wrapper topanelAutoFillso the panel itself scrolls within the fixed-height sticky container